org.freesmartphone.GSM.SMS

[Vesa Pikki]

Hi

Gsmd2 uses libsms (which itself uses sqlite) to store the sms messages, 
which is were my suggestions initiated from.
Bernhard made a lot of good points and my suggestions would have been 
better suited for pyPimd. Keeping in mind that gsm daemon should be 
really low level I tried removing all the high level stuff from gsmd2 
and still be able to use it with sms application. Here are some 
questions/comments that came in mind:

Should Get/SetServiceBearer, ListMessages be put to SIM interface instead?

Listmessages should also have status parameter that maps to +CMGL's 
parameter.
Here's a quote from Telit's specifications on +CMGL:
Parameter:
<stat>
 0 - new message
 1 - read message
 2 - stored message not yet sent
 3 - stored message already sent
 4 - all messages.

So it could look something like:
<method name="ListMessages">
<annotation name="org.freedesktop.DBus.GLib.Async" value="fso_gsm_sms"/>
<arg type="s" name="status" direction="in"/>
<arg type="ai" name="indices" direction="out"/>
</method>

status could have the following values: new,read,sending,sent,all


Are GetStorageSpaces, GetDefaultStorageSpace and SetDefaultStorageSpace 
still necessary?

How about DeleteMessage and RetrieveMessage?

SendMessage could be modified to accept message and the phone number to 
directly send a sms. Another SendMessage method could be added to send a 
stored message with an index (like it is at the moment). The latter 
method could be added to SIM instead of SMS.

-- 
Vesa Pikki