Questions, notes and comments

[Vesa Pikki]

Hi

Here is some of the questions, notes and comments that I wrote down when 
implementing freesmartphone's dbus api.

General notes:
Timeout and other error replies to method calls should be specified.

org.freesmartphone.GSM.Storage.xml:
Most methods have int primary_key, modify entry has string primary_key
org.freesmartphone.GSM.SMS uses int index, should they all be string 
primary_keys?

org.freesmartphone.GSM.Phonebook.xml:
StoreEntry has index with direction "in", should it modified to be like 
Storage that there are methods StoreEntry and a separate ModifyEntry

org.freesmartphone.GSM.SMS.xml:
SMS doesn't have any methods to modify a message. For drafts it might be 
useful.

org.freesmartphone.GSM.Call.xml
Microphone and/or speaker volume settings (the ones that are done with 
at-commands AT+CRSL and AT+CLVL) might be added here.

org.freesmartphone.GSM.Network.xml
SubscriberNumbers has string argument, should it be string array instead?

org.freesmartphone.GSM.Device.xml
GetFeatures should propably be of type a{sv}?

SetFunction never quite understood the meaning of this.


-- 
Vesa Pikki