[OE stablebranch] [RFC] Commit and review policy

Leon Woestenberg leon.woestenberg at gmail.com
Sun Mar 30 12:10:39 CEST 2008


>
> > 2. Once approved by two developers (with at least one OE stable branch
> > maintainer),
>
> We should adopt kernel style Signed-off-by <foo at bar.org> lines
>

Signed-off-by: Leon Woestenberg <leon at sidebranch.com>

Note the double colon, and name. I recommend having this available as a
macro.


The commit message should look like:
>
> - ---
> linux 2.6.24: backport rtc fixes for simpad
>
> Revision: ead8fe4eb9f4a05e10d6ad072d127ba6aa6820f7
> Author: woglinde2 at openembedded.org
> Date: 2008-03-25T17:30:23
>
> Signed-off-by: Bernhard Simpad <bernhard at opensimpad.org>
> Signed-off-by: Koen Kooi <koen at openembedded.org>
>
>
Commit messages shoule have a short (brief) single-line comment. If more if
needed, this is followed by two newlines, then the rest of the message.
This is recommended practice as the first line is often shown by several SCM
tools in their summaries.

This latter RFC is applicable for .dev as well.

Regards,
-- 
Leon


More information about the Openembedded-stablebranch mailing list