[OE stablebranch] Commit 4c3ac9a37424daae6820e4290a1a5bc8343786d3

[Justin Patrin]

On Mon, Apr 7, 2008 at 2:18 AM, Koen Kooi <k.kooi at student.utwente.nl> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>
>  Hi,
>
>  There hasn't been a review for 4c3ac9a37424daae6820e4290a1a5bc8343786d3
> [1], so why was it committed? The review policy [2] is there because this is
> suppossed to be a *stable* branch, not a commit-random-stuff-without-review
> branch.
>  This revision will get disapproved if it isn't properly reviewed before
> midnight (UTC) (approx 14.5 hours from now).
>

All I can say is that git is not buildable and stable is not useful
without this patch. Revision a42936f86bfc2fe328a115dd331286fc71e8156a
[1], comitted by rwhitby at nslu2-linux.org added this patch to the list
of patches [2] but did not include the patch file itself, causing a
failure on patch. I looked in .dev and found the patch [3], which did
exactly what the commit message for the above revision stated it
should, and allowed the build to continue. I assumed that rwhitby's
commit had been approved in some way so I just comitted what appeared
to be his intention.

I highly recommend either keeping this revision or disapproving
a42936f86bfc2fe328a115dd331286fc71e8156a as well as stable *cannot
build* with only the one.

[1] http://amethyst.openembedded.net/oe/viewmtn/viewmtn.py/revision/info/a42936f86bfc2fe328a115dd331286fc71e8156a
[2] http://amethyst.openembedded.net/oe/viewmtn/viewmtn.py/revision/diff/c05cfe12c0630a70a42fcc124768d299a8de7cdd/with/a42936f86bfc2fe328a115dd331286fc71e8156a/packages/git/git.inc
[3] http://amethyst.openembedded.net/oe/viewmtn/viewmtn.py/revision/file/6ba02de8376bd7b3c4fe9e2a9052dec09ad8af6c/packages/git/files/git-gui-install-mode-arg-spaces.patch

>  regards,
>
>  Koen
>
>  [1]
> http://amethyst.openembedded.net/oe/viewmtn/viewmtn.py/revision/info/4c3ac9a37424daae6820e4290a1a5bc8343786d3
>  [2] See the thread at
> http://lists.linuxtogo.org/pipermail/openembedded-stablebranch/2008-March/000001.html
>  -----BEGIN PGP SIGNATURE-----
>  Version: GnuPG v1.4.5 (Darwin)
>
>  iD8DBQFH+ebdMkyGM64RGpERAuZjAJ9cKQRuP4cNWiAPXanbpKH7ge6kTgCeO9dA
>  I64ZQc1b92WnfKtDjW0Ifvw=
>  =WEMq
>  -----END PGP SIGNATURE-----
>



-- 
Justin Patrin