[oe] [PATCH v4] mypaint: new recipe for version 0.9.1
paulepanter at users.sourceforge.net
Wed May 4 20:51:46 CEST 2011
Am Mittwoch, den 04.05.2011, 18:57 +0200 schrieb Eric Bénard:
> On 04/05/2011 18:48, Paul Menzel wrote:
> > Am Mittwoch, den 04.05.2011, 17:34 +0200 schrieb Eric Bénard:
> >> On 04/05/2011 10:56, Paul Menzel wrote:
> >>> Please remember to add what build configuration you used. (You can just
> >>> paste it from the BitBake output.)
> >> You asked this several times on the list but this part is not in the commit
> >> log policy : http://wiki.openembedded.org/index.php/Commit_log_example
> > I know and therefore I do *not* NACK patches and even commit them if the
> > build configuration is not in the commit message. Still I think it
> > belongs to useful commit messages to be able to reproduce something and
> > therefore I am asking for it.
> maybe this information could go under the commit log, between two --- lines as
> this makes git log more difficult to read and this information in mostly
> useful for patch review.
In my opinion it is not so important for the review but for later bug
Take the following example.
$ git log recipes/prboom/
Why did those compilation fixes needed to be applied. Knowing what
distribution and machine was used I could conclude what other versions
of recipes were used and do some debugging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: This is a digitally signed message part
More information about the Openembedded-devel