[oe] [PATCH] tcp-wrappers: place LIBS after object files
enrico.scholz at sigma-chemnitz.de
Tue Apr 26 15:53:56 CEST 2011
Paul Menzel <paulepanter at users.sourceforge.net> writes:
>> From: Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de>
> it seems you need to update your Git configuration to your common
> email address.
Both addresses are in use; some patches are created at home when I work
on a personal project (-> tu-chemnitz.de address), some patches at work
(-> sigma-chemnitz.de address).
> The diff could have been smaller, but no big problem.
how? three places must be changed (removal of $(LIBS) from old LINKFLAGS,
removal of superflous ';' and adding of $(LIBS) to link command).
>> +-SHLIB_OBJ= $(addprefix shared/, $(LIB_OBJ));
>> ++SHLIB_OBJ= $(addprefix shared/, $(LIB_OBJ))
> The »;« was superfluous, since no command followed?
yes; and it would break the build because it terminates the $(CC) command
and $(LIBS) would be interpreted as the start of a new command.
>> ++ $(CC) $(LDFLAGS) -o $(SHLIB) $(SHLINKFLAGS) $(SHLIB_OBJ) $(LIBS)
> Is this patch already upstream?
woglinde gave his ack on irc and I submitted it.
More information about the Openembedded-devel