[Bitbake-dev] [patch] don't delete dictionary entries that don't exist

[Cliff Brake]

On Tue, Jun 15, 2010 at 5:42 PM, Cliff Brake <cliff.brake at gmail.com> wrote:
> On Thu, Jun 3, 2010 at 5:17 AM, Richard Purdie <rpurdie at rpsys.net> wrote:
>> On Wed, 2010-06-02 at 12:38 -0400, Cliff Brake wrote:
>>> I ran into some issues with srctree that are fixed by the following.
>>> Not sure if this is the correct, or valid fix, but perhaps someone can
>>> review:
>>>
>>> http://cgit.bec-systems.com/cgit.cgi/bitbake/commit/?h=cbrake/1.10-srctree-fixes&id=c6fe73d986d596dca7f76bd277cf279cd5c21308
>>
>> This is just a bandaid over a bigger problem.
>>
>> The question is why the task isn't in that list. It should be either
>> returning success or failure once and that code should work. So it
>> sounds like a reference counting type issue and the question is why
>> srctree is breaking the refcounting?
>>
>> I'd really like to get to the underlying problem. Do you have a complete
>> event log for a case when this happens? Are the number of
>> starts/succeeds/fails balanced? I know you uncommented the "print event"
>> debug line and this info should help understand whats going on.
>
> cbrake at happy:/scratch/oe/oe-build/bitbake$ bitbake -DDDD autotools-demo > x2
> Traceback (most recent call last):
>  File "/scratch/oe/oe-build/bitbake/bin/bitbake", line 203, in <module>
>    ret = main()
>  File "/scratch/oe/oe-build/bitbake/bin/bitbake", line 194, in main
>    return_value = ui_init(serverConnection.connection, serverConnection.events)
>  File "/scratch/oe/oe-build/bitbake/lib/bb/ui/knotty.py", line 62, in init
>    helper.eventHandler(event)
>  File "/scratch/oe/oe-build/bitbake/lib/bb/ui/uihelper.py", line 31,
> in eventHandler
>    del self.running_tasks[event.pid]
> KeyError: 19335
>
> Logs are available below:
>
> http://bec-systems.com/oe/srctree_DDDD.txt
> http://bec-systems.com/oe/srctree_events.txt
>
> This is very easy to duplicate:
>
> cd <oe meta data>/recipes/
> git clone git://git.bec-systems.com/autotools-demo
> cd -
> bitbake autotools-demo
>
> Note, you have to do a clean between bitbakes, or the problem goes away.

As to unbalanced Start/Succeeded, the

NOTE: package autotools-demo-1.1-r0: task do_populate_sysroot: Started

is Started, but I don't ever see a Succeeded.

Thanks,
Cliff