[Bitbake-dev] a couple more general questions about bitbake

[Richard Purdie]

On Thu, 2010-01-14 at 10:25 -0500, Robert P. J. Day wrote:
> at the moment, i've checked out the git repo for bitbake and, in an
> attempt to finally understand how all this bitbake/OE stuff works
> (while learning python at the same time), i'm perusing the code, and
> i'm wondering if there's value in my submitting patches to clean
> things up, mostly regarding documentation.

I'm open to patches which clean some of this stuff up. The manual is
suffering bitrot :(.

>   as a start, chapter 3 (File Download support) of the user manual
> doesn't seem to mention a number of download possibilities, such as
> ssh, mercurial, bzr, wget, etc, that are clearly defined in
> lib/bb/fetch/.

Yes, these were all added after the manual was written and it was never
updated.

>   in other cases, comments look a bit off and the code might be off a
> bit.  for instance, here in lib/bb/fetch/local.py,
> 
> class Local(Fetch):
>     def supports(self, url, urldata, d):
>         """
>         Check to see if a given url can be fetched with cvs.
>         """
>         return urldata.type in ['file','patch']
> 
> 
>   i'm assuming that the comment referring to "cvs" is a copy-and-paste
> booboo, while (and i might be misreading this) a local fetch is
> defined by a urldata.type of either 'file' or 'patch'.  why 'patch'?
> i thought the urldata.type is based on the protocol in the URN.  but
> patches are still defined by "file:///", are they not?  or am i just
> misunderstanding this?  thanks.

As you suspect this is a copy and paste error. It looks like you can
specify a patch as patch://, just we never do that. I never knew that
existed and we can probably drop that (IMO) as patches can be from a
variety of sources.

Cheers,

Richard