[Angstrom-devel] [H5400-port] Merging .c files from arch/arm/mach-pxa/h5400 back to h5400.c

[Paul Sokolovsky]

Hello,

On Sun, 10 Feb 2008 22:43:32 +0100
"Michal Panczyk" <mpanczyk at gmail.com> wrote:

> Hello all
> 
> A new year has come - so did the plans. Last year, before the
> kernel-discuss went down (!!!), there was some work done for splitting
> the baisic drivers of h5000 devices from the h5400.c file to separate
> files. As the result some new files are now listed in
> arch/arm/mach-pxa/h5400/ dir :
> h5400_audio.c (removed by recent change in CVS)
> h5400_bl.c
> h5400_bt.c
> h5400_lcd.c
> h5400_wifi.c
> 
> This year the plans have changed - the plan is to put everything back
> to h5400.c file again... (see OE bug #3549 - just remember that the
> temporary address change - bugs.openembedded.net). So I am going to
> start work on bringing back the functions included in these files to
> h5400.c. I got positive response from Paul Sokolovsky and Anton (who
> spent some time on previous plan.....). The work does not seem too
> hard, as most of code is well documented (commented :P). I am going to
> go by each file in alphabetical order and follow the style included in
> h2200.c (as I worked with that a little and I know it is ok) and
> submit patches in couple of next days.

	The plan is good. Note that it doesn't have to be done in one
turn - I myself don't feel comfortable with merging all stuff into
h4000.c, but anyway, it's just the matter of fact that we'll need to
have that organization - one, at most 2 files per machine, to get stuff
upstream. And indeed, one of the question here is to still have some
consistent internal structure, I'm glad you're thinking about that,
following h2200.c is a good plan.

> 
> The hardest one for me seems to be the wifi driver - as I know that it
> does not work in current state (I tried that form module....). If I
> have some problems with that one or any other one I will ask for some
> help here or at kernel-bugs mailing list.
> 
> I would like to get the patches tested even before going to OE.dev. I
> know that most of people interested in looking through the patches
> will know how to apply them and build proper image, but there are also
> some people (who I guess have some more time) that would just like to
> load the image and start testing. I think that information form the
> test is quite valuable, so I would like to build and share an image
> (probably console-image). I have started (again) the initial work on
> some kind of test procedure available for everybody of testing support
> of hardware components -
> http://www.linuxtogo.org/gowiki/UniversalTestProcedure It is based on
> my never sent report about current state of support of h5000 in
> angstrom, but in the current state it is even unreadable (uh - how I
> love formatting the wiki pages....). In couple of days it is going to
> look better, so I hope the future testers could use it quite
> simple.....

Looks good.

> I would be grateful for comment on that plan too - it seems to be
> against the current 'policy' (every image has to go through
> autobuilder), but it seems to be straight forward...

Well, general availability images must go thru autobuilder. There's
nothing wrong with building own testing images and sharing them with
testers. Just please reserve share of your efforts towards making sure
that the changes you made are pushed to the stable branch and then
tested with autobuilder images. That does take effort, but is the only
way to ensure sustainable progress, and not what we had before -
multi-vector efforts of many people giving too little overall progress
yet at the high price of doing the same stuff again and again.

> 
> Also, Koen (I am not sure if You are subscribed to the list)- I have
> seen Your comment at angstrom-devel
> (http://article.gmane.org/gmane.linux.distributions.angstrom.devel/2058)
> about getting Wifi to work. I don't want to mess up Your work, so if
> You too have some comments pls share them here....
> 
> If there are any comments("go go go","the plan is wrong because....",
> "don't mess up with my code..." "leave this - there are move important
> things to do in the port", "wait for 2.6.24 merger"), proposals please
> submit them to h5400-port as most interested people are subscribed
> there.
> 
> Cheers
> Michal Panczyk
> _______________________________________________
> H5400-port mailing list
> H5400-port at handhelds.org
> https://www.handhelds.org/mailman/listinfo/h5400-port



-- 
Best regards,
 Paul                          mailto:pmiscml at gmail.com