[Angstrom-devel] h5000 - add bluetooth support to images

[Paul Sokolovsky]

Hello,

On Mon, 4 Feb 2008 23:38:09 +0100
"Michal Panczyk" <mpanczyk at gmail.com> wrote:

> Hi!
> I have spotted that h5000 images are missing h5400_bt module installed
> by default. This patch fixes that. 

Nak. Machine-specific modules should not go into task-base, that's not
scalable. There're MACHINE_EXTRA_RRECOMMENDS just for that (don't
forget that task-base's PR must be still bumped for such change). So,
here's the patch which was committed:

--- conf/machine/h5000.conf     e03a562f647e39de325cf64e33abb934e96da504
+++ conf/machine/h5000.conf     b0fe52891e392a5d43162145964546c7517d27e4
@@ -27,6 +27,7 @@ MACHINE_EXTRA_RRECOMMENDS = " kernel-mod
 MACHINE_EXTRA_RDEPENDS = "kernel ipaq-boot-params"
 MACHINE_EXTRA_RRECOMMENDS = " kernel-module-h5400-lcd \
                              kernel-module-h5400-battery \
+                             kernel-module-h5400-bt \
                              kernel-module-snd-soc-h5000 \
                              kernel-module-i2c-pxa"
 
============================================================
--- packages/tasks/task-base.bb 1a4f000020453dc9598a87cbb8a1df9e88bc5c96
+++ packages/tasks/task-base.bb 2ebcd1a884302a4643dd61431a84aadea41cb978
@@ -1,5 +1,5 @@ DESCRIPTION = "Merge machine and distro 
 DESCRIPTION = "Merge machine and distro options to create a basic
machine task/package" -PR = "r59"
+PR = "r60"
 


> Is was generated against
> angstrom-2007.12-stable branch, but it applies to .dev too. For the
> future - against which branch should I generate patches ?

As was RFCed earlier, all patches should whenever possible go into .dev
branch, and then be explicitly RFCed for merging into stable branch.
The whole process should be handled by patch author (or it is simply
non-scalable). That's why using bugtracker is useful - it's not easy to
track what was applied where, and if was pushed to feeds.

> 
> -- 
> 
> Michal



-- 
Best regards,
 Paul                          mailto:pmiscml at gmail.com